Bump version

https://github.com/minio/minio/issues/18906
https://github.com/minio/docs/issues/1116
https://github.com/minio/minio/pull/18846

CloudronManifest.json

@@ -5,23 +5,33 @@
   "description": "file://DESCRIPTION.md",
   "changelog": "file://CHANGELOG",
   "tagline": "Distributed object storage",
-  "version": "1.164.1",
+  "version": "3.12.12",
+  "upstreamVersion": "2024-02-13T15-35-11Z",
   "healthCheckPath": "/minio/login",
+  "memoryLimit": 2147483648,
   "httpPort": 8000,
+  "httpPorts": {
+    "API_SERVER_DOMAIN": {
+      "title": "API Server Domain",
+      "description": "The domain name for MinIO (S3) API requests",
+      "containerPort": 9000,
+      "defaultValue": "minio-api"
+    }
+  },
   "addons": {
     "localstorage": {}
   },
   "manifestVersion": 2,
   "website": "http://www.minio.io",
-  "minBoxVersion": "5.3.0",
+  "minBoxVersion": "7.1.2",
   "forumUrl": "https://forum.cloudron.io/category/69/minio",
   "documentationUrl": "https://docs.cloudron.io/apps/minio/",
   "contactEmail": "support@cloudron.io",
   "icon": "logo.png",
   "tags": [ "storage", "hosting", "s3", "objectstore" ],
   "mediaLinks": [
-    "https://screenshots.cloudron.io/io.minio.cloudronapp/minio-browser-gateway.png",
+    "https://screenshots.cloudron.io/io.minio.cloudronapp/pic1.png",
-    "https://screenshots.cloudron.io/io.minio.cloudronapp/minio-browser.png"
+    "https://screenshots.cloudron.io/io.minio.cloudronapp/pic2.png"
   ],
   "postInstallMessage": "file://POSTINSTALL.md"
 }

DESCRIPTION.md

@@ -1,29 +1,29 @@
-This app packages Minio <upstream>2021-05-20T22-31-44Z</upstream>.
+## About
 
 Minio is a distributed object storage server built for cloud applications and devops.
 
-### Features
+## Features
 
-#### Amazon S3 Compatible
+### Amazon S3 Compatible
 
 Minio implements Amazon S3 v4 APIs. Minio also includes client SDKs and a console utility.
 
-#### Minimalist Design
+### Minimalist Design
 
 Minio is deeply influenced by minimalism. We believe that only simple things scale.
 
-#### Apache License 2.0
+### Apache License 2.0
 
 Minio is free software, released under Apache license v2.0. Minio has an active developer and user community.
 
-#### Lambda Functions
+### Lambda Functions
 
 Minio triggers Lambda functions through event notification service. In addition Minio also supports simple queueing service for AMQP, Elasticsearch, Redis, NATS and Postgres targets.
 
-#### Erasure Code & Bitrot Protection
+### Erasure Code & Bitrot Protection
 
 Minio protects data against hardware failures and silent data corruption using erasure code and checksums. You may lose half the number of drives and still recover from it.
 
-#### Written in Go
+### Written in Go
 
 Go is an emerging language of choice for modern cloud infrastructure projects. Go language enables Minio to be highly concurrent and lightweight.

Dockerfile

@@ -1,14 +1,16 @@
-FROM cloudron/base:3.0.0@sha256:455c70428723e3a823198c57472785437eb6eab082e79b3ff04ea584faf46e92
+FROM cloudron/base:4.2.0@sha256:46da2fffb36353ef714f97ae8e962bd2c212ca091108d768ba473078319a47f4
-
-ARG VERSION=RELEASE.2021-05-20T22-31-44Z
-
-RUN mkdir -p /app/code \
-    && wget https://dl.min.io/server/minio/release/linux-amd64/minio.${VERSION} -O /app/code/minio \
-    && chmod +x /app/code/minio
 
+RUN mkdir -p /app/code
 WORKDIR /app/code
 
-ADD start.sh /app/code/start.sh
+ARG VERSION=RELEASE.2024-02-13T15-35-11Z
-ADD minio-credentials /app/code/minio-credentials
+
+# sometimes here https://dl.min.io/server/minio/release/linux-amd64/archive/
+# RUN wget https://dl.min.io/server/minio/release/linux-amd64/minio.${VERSION} -O /app/code/minio && chmod +x /app/code/minio
+RUN wget https://dl.min.io/server/minio/release/linux-amd64/archive/minio.${VERSION} -O /app/code/minio && chmod +x /app/code/minio
+# https://dl.min.io/client/mc/release/linux-amd64/
+RUN wget https://dl.min.io/client/mc/release/linux-amd64/mc -O /app/code/mc && chmod +x /app/code/mc
+
+COPY env.sh start.sh /app/code/
 
 CMD [ "/app/code/start.sh" ]

README.md

@@ -34,3 +34,11 @@ npm install
 PATH=$PATH:node_modules/.bin mocha --bail test.js
 ```
 
+## Notes
+
+MinIO Console is an embedded web-based object browser built into MinIO Server
+
+## Multi-domain
+
+MINIO_DOMAIN=domain.com env var can be set to server DNS style requests as bucket.domain.com . This requires the platform code to set aliases for the httpPorts and not the primaryport.
+

env.sh

@@ -0,0 +1,9 @@
+# Add custom minio configuration to this file. Restart the app for changes to take effect.
+
+export CLOUDRON_MINIO_STARTUP_ARGS='server /app/data/data'
+
+# See https://docs.min.io/minio/baremetal/reference/minio-server/minio-server.html#envvar.MINIO_ROOT_USER
+# You can use pwgen -1s 64 to generate usernames and passwords
+export MINIO_ROOT_USER=minioadmin
+export MINIO_ROOT_PASSWORD=minioadmin
+

minio-credentials

@@ -1,41 +0,0 @@
-#!/usr/bin/env node
-
-'use strict';
-
-const fs = require('fs');
-
-const MINIO_CONFIG = '/app/data/data/.minio.sys/config/config.json';
-
-function usage() {
-    console.log('Usage:\n');
-    console.log('\tminio-credentials get');
-    console.log('\tminio-credentials set <access key> <secret key>');
-    console.log();
-}
-
-let config = JSON.parse(fs.readFileSync(MINIO_CONFIG, 'utf8'));
-let adminCredentials = config['credentials']['_'];
-let accessKey = adminCredentials.filter(kv => kv.key === 'access_key')[0];
-let secretKey = adminCredentials.filter(kv => kv.key === 'secret_key')[0];
-
-if (process.argv[2] === 'get') {
-    console.log('Access Key:', accessKey.value);
-    console.log('Secret Key:', secretKey.value);
-} else if (process.argv[2] === 'set') {
-    if (process.argv.length !== 5) return usage();
-
-    // https://docs.aws.amazon.com/IAM/latest/APIReference/API_CreateAccessKey.html
-    if (process.argv[4].length < 5) return console.log('secret key must be atleast 5 characters');
-    if (!/^[\w+=,.@-]+$/.test(process.argv[3])) return console.log('access key has invalid characters');
-
-    accessKey.value = process.argv[3];
-    if (process.argv[4].length < 8) return console.log('secret key must be atleast 8 characters');
-
-    secretKey.value = process.argv[4];
-
-    fs.writeFileSync(MINIO_CONFIG, JSON.stringify(config), 'utf8');
-    console.log('Credentials updated. Restart minio app for new credentials to take effect.\n');
-} else {
-    usage();
-}
-

start.sh

@@ -4,16 +4,23 @@ set -eu
 
 mkdir -p /app/data/data /run/minio/config /run/minio/certs
 
-# minio is used for backups at times and has a large number of files. optimize by checking if files
+# env vars take precedence over config.yaml (https://github.com/minio/minio/blob/master/docs/distributed/CONFIG.md#things-to-know)
-# are actually in correct chown state
+[[ ! -f /app/data/env.sh ]] && cp /app/code/env.sh /app/data/env.sh
+source /app/data/env.sh
+
+# https://docs.min.io/minio/baremetal/reference/minio-server/minio-server.html#envvar.MINIO_SERVER_URL
+export MINIO_SERVER_URL="https://${API_SERVER_DOMAIN}"
+export MINIO_BROWSER_REDIRECT_URL="https://${CLOUDRON_APP_DOMAIN}"
+
+if [[ ! -d /app/data/mc_config ]]; then
+    mkdir -p /app/data/mc_config
+    /app/code/mc --config-dir /app/data/mc_config &> /dev/null || true
+fi
+
+# minio is used for backups at times and has a large number of files. optimize by checking if files are actually in correct chown state
 echo "==> Changing ownership"
 [[ $(stat --format '%U' /app/data/data) != "cloudron" ]] && chown -R cloudron:cloudron /app/data
 
-[[ ! -f /app/data/env.sh ]] && echo -e "# Add custom minio configuration to this file. Restart the app for changes to take effect.\n\nexport CLOUDRON_MINIO_STARTUP_ARGS='server /app/data/data'" > /app/data/env.sh
-
-source /app/data/env.sh
-
-# the --config-dir is deprecated and not used. but without it, minio will try to create $HOME/.minio :/ same for --certs-dir
 echo "==> Starting minio"
-exec /usr/local/bin/gosu cloudron:cloudron /app/code/minio --certs-dir /run/minio/certs --config-dir /run/minio/config --quiet ${CLOUDRON_MINIO_STARTUP_ARGS} --address :8000 
+exec /usr/local/bin/gosu cloudron:cloudron /app/code/minio --quiet ${CLOUDRON_MINIO_STARTUP_ARGS} --address :9000 --console-address :8000
 

test/package.json

@@ -9,9 +9,10 @@
   "author": "",
   "license": "ISC",
   "dependencies": {
-    "chromedriver": "^89.0.0",
+    "chromedriver": "^121.0.0",
     "expect.js": "^0.3.1",
-    "mocha": "^8.3.2",
+    "mocha": "^10.3.0",
-    "selenium-webdriver": "^3.6.0"
+    "selenium-webdriver": "^4.17.0",
+    "superagent": "^8.1.2"
   }
 }

test/test.js

@@ -1,31 +1,34 @@
 #!/usr/bin/env node
 
+/* jshint esversion: 8 */
 /* global describe */
 /* global before */
 /* global after */
 /* global it */
+/* global xit */
 
 'use strict';
 
 require('chromedriver');
 
-var execSync = require('child_process').execSync,
+const execSync = require('child_process').execSync,
     expect = require('expect.js'),
+    fs = require('fs'),
     path = require('path'),
-    { Builder, By, Key, until } = require('selenium-webdriver'),
+    superagent = require('superagent'),
+    timers = require('timers/promises'),
+    { Builder, By, until } = require('selenium-webdriver'),
     { Options } = require('selenium-webdriver/chrome');
 
-
 describe('Application life cycle test', function () {
     this.timeout(0);
 
     const LOCATION = 'test';
-    const TEST_TIMEOUT = 10000;
+    const TEST_TIMEOUT = 30000;
-    const EXEC_ARGS = { cwd: path.resolve(__dirname, '..'), stdio: 'inherit' };
     const BUCKET = 'cloudrontestbucket';
+    const EXEC_ARGS = { cwd: path.resolve(__dirname, '..'), stdio: 'inherit' };
 
-    var app;
+    let browser, app;
-    var browser;
 
     before(function () {
         browser = new Builder().forBrowser('chrome').setChromeOptions(new Options().windowSize({ width: 1280, height: 1024 })).build();
@@ -35,132 +38,87 @@ describe('Application life cycle test', function () {
         browser.quit();
     });
 
+    async function waitForElement(elem) {
+        await browser.wait(until.elementLocated(elem), TEST_TIMEOUT);
+        await browser.wait(until.elementIsVisible(browser.findElement(elem)), TEST_TIMEOUT);
+    }
+
     function getAppInfo() {
         var inspect = JSON.parse(execSync('cloudron inspect'));
         app = inspect.apps.filter(function (a) { return a.location.indexOf(LOCATION) === 0; })[0];
         expect(app).to.be.an('object');
     }
 
-    function pageLoaded() {
+    async function login(accessKey='minioadmin', secretKey='minioadmin') {
-        return browser.wait(until.elementLocated(By.className('page-load pl-0 pl-1')), TEST_TIMEOUT);
+        await browser.get(`https://${app.fqdn}/login`);
+        await waitForElement(By.id('accessKey'));
+        await browser.findElement(By.id('accessKey')).sendKeys(accessKey);
+        await browser.findElement(By.id('secretKey')).sendKeys(secretKey);
+        await browser.findElement(By.xpath('//button[@id="do-login"]')).click();
+        await waitForElement(By.xpath('//span[contains(text(), "Buckets")]'));
+        await timers.setTimeout(5000);
     }
 
-    function visible(selector) {
+    async function logout() {
-        return browser.wait(until.elementLocated(selector), TEST_TIMEOUT).then(function () {
+        await browser.get(`https://${app.fqdn}/`);
-            return browser.wait(until.elementIsVisible(browser.findElement(selector)), TEST_TIMEOUT);
+        await waitForElement(By.xpath('//span[contains(text(), "Buckets")]'));
-        });
+        const button = await browser.findElement(By.xpath('//button[@id="sign-out"]'));
+        await browser.executeScript('arguments[0].scrollIntoView(false)', button);
+        await button.click();
+        await waitForElement(By.id('accessKey'));
     }
 
-    function login(accessKey, secretKey, callback) {
+    async function addBucket() {
-        browser.manage().deleteAllCookies();
+        await browser.get(`https://${app.fqdn}/buckets`);
-        browser.get('https://' + app.fqdn).then(function () {
+        await waitForElement(By.xpath('//button[@id="create-bucket"]'));
-            return visible(By.id('accessKey'));
+        await browser.findElement(By.xpath('//button[@id="create-bucket"]')).click();
-        }).then(function () {
+        await browser.sleep(2000);
-            return browser.findElement(By.id('accessKey')).sendKeys(accessKey);
+        await browser.findElement(By.xpath('//input[@id="bucket-name"]')).sendKeys(BUCKET);
-        }).then(function () {
+        await browser.findElement(By.xpath('//button[@id="create-bucket"]')).click();
-            return browser.findElement(By.id('secretKey')).sendKeys(secretKey);
+        await waitForElement(By.xpath(`//h1[contains(text(), "${BUCKET}")]`));
-        }).then(function () {
+        await timers.setTimeout(5000);
-            // return browser.findElement(By.className('lw-btn')).click();
-            return browser.findElement(By.tagName('form')).submit();
-        }).then(function () {
-            return browser.wait(until.elementLocated(By.id('top-right-menu')), TEST_TIMEOUT);
-        }).then(function () {
-            callback();
-        });
     }
 
-    function logout(callback) {
+    async function checkBucket() {
-        browser.get('https://' + app.fqdn);
+        await browser.get(`https://${app.fqdn}/buckets`);
-
+        await waitForElement(By.xpath(`//h1[contains(text(), "${BUCKET}")]`));
-        pageLoaded().then(function () {
-            return visible(By.id('top-right-menu'));
-        }).then(function () {
-            return browser.findElement(By.id('top-right-menu')).click();
-        }).then(function () {
-            if (app.manifest.version === '1.137.0') {
-                return visible(By.xpath('//*[text()="Sign Out "]'));
-            } else {
-                return visible(By.xpath('//*[contains(text(), "Logout")]'));
-            }
-        }).then(function () {
-            if (app.manifest.version === '1.137.0') {
-                return browser.findElement(By.xpath('//*[text()="Sign Out "]')).click();
-            } else {
-                return browser.findElement(By.xpath('//*[contains(text(),"Logout")]')).click();
-            }
-        }).then(function () {
-            return browser.wait(until.elementLocated(By.id('accessKey')), TEST_TIMEOUT);
-        }).then(function () {
-            callback();
-        });
     }
 
-    function addBucket(callback) {
+    async function checkRedirect() {
-        browser.get('https://' + app.fqdn);
+        const response = await superagent.get(`https://${app.secondaryDomains[0].fqdn}`).set('User-Agent', 'Mozilla/5.0').redirects(0).ok(() => true);
-
+        expect(response.status).to.be(307);
-        pageLoaded().then(function () {
+        expect(response.headers.location).to.be(`https://${app.fqdn}`);
-            return visible(By.className('fa-plus'));
-        }).then(function () {
-            return browser.findElement(By.className('fa-plus')).click();
-        }).then(function () {
-            const c = 'fa-hdd';
-            return visible(By.className(c));
-        }).then(function () {
-            const c = 'fa-hdd';
-            return browser.findElement(By.className(c)).click();
-        }).then(function () {
-            return visible(By.xpath('//*[@class="modal-body"]/form/div/input'));
-        }).then(function () {
-            return browser.findElement(By.xpath('//*[@class="modal-body"]/form/div/input')).sendKeys(BUCKET);
-        }).then(function () {
-            return browser.findElement(By.xpath('//*[@class="modal-body"]/form')).submit();
-        }).then(function () {
-            return visible(By.xpath('//*[@class="main"]/a[text()="' + BUCKET + '"]'));
-        }).then(function () {
-            callback();
-        });
     }
 
-    function checkBucket(callback) {
+    async function checkApi() {
-        browser.get('https://' + app.fqdn);
+        const response = await superagent.get(`https://${app.secondaryDomains[0].fqdn}`).ok(() => true);
-
+        expect(response.status).to.be(403);
-        pageLoaded().then(function () {
+        expect(response.body.toString('utf8')).to.contain('<Code>AccessDenied</Code>');
-            return browser.findElement(By.xpath(`//a[contains(text(), ${BUCKET})]`));
-        }).then(function () {
-            callback();
-        });
-    }
-
-    function openSettings(callback) {
-        browser.get('https://' + app.fqdn);
-
-        pageLoaded().then(function () {
-            return visible(By.id('top-right-menu'));
-        }).then(function () {
-            return browser.findElement(By.id('top-right-menu')).click();
-        }).then(function () {
-            return visible(By.xpath('//*[contains(text(), "Change Password")]'));
-        }).then(function () {
-            return browser.findElement(By.xpath('//*[contains(text(),"Change Password")]')).click();
-        }).then(function () {
-            return browser.wait(until.elementLocated(By.xpath('//*[contains(text(), "Change Password")]')), TEST_TIMEOUT);
-        }).then(function () {
-            callback();
-        });
     }
 
     xit('build app', function () { execSync('cloudron build', EXEC_ARGS); });
-    it('install app', function () { execSync('cloudron install --location ' + LOCATION, EXEC_ARGS); });
+    it('install app', async function () {
+        execSync(`cloudron install --location ${LOCATION} --secondary-domains API_SERVER_DOMAIN=${LOCATION}-api`, EXEC_ARGS);
+        await timers.setTimeout(10000);
+    });
 
     it('can get app information', getAppInfo);
 
     it('can login', login.bind(null, 'minioadmin', 'minioadmin'));
     it('can add bucket', addBucket);
-    it('can open settings', openSettings);
     it('can logout', logout);
+    it('does redirect', checkRedirect);
+    it('check api', checkApi);
 
-    it('can change credentials', function () {
+    it('can change credentials', async function () {
-        execSync(`cloudron exec --app ${app.id} -- /app/code/minio-credentials set minioakey minioskey`, EXEC_ARGS);
+        let data = fs.readFileSync(path.join(__dirname, '../env.sh'), 'utf8');
+        data = data
+            .replace(/MINIO_ROOT_USER=.*/, 'MINIO_ROOT_USER=minioakey')
+            .replace(/MINIO_ROOT_PASSWORD=.*/, 'MINIO_ROOT_PASSWORD=minioskey');
+        fs.writeFileSync('/tmp/env.sh', data);
+        execSync(`cloudron push --app ${app.id} /tmp/env.sh /app/data/env.sh`, EXEC_ARGS);
+        execSync(`cloudron restart --app ${app.id}`, EXEC_ARGS);
+        await timers.setTimeout(10000);
     });
 
     it('can restart app', function () { execSync(`cloudron restart --app ${app.id}`, EXEC_ARGS); });
@@ -168,30 +126,37 @@ describe('Application life cycle test', function () {
     it('can login', login.bind(null, 'minioakey', 'minioskey'));
     it('has bucket', checkBucket);
     it('can logout', logout);
+    it('does redirect', checkRedirect);
+    it('check api', checkApi);
 
     it('backup app', function () { execSync('cloudron backup create --app ' + app.id, EXEC_ARGS); });
-    it('restore app', function () {
+    it('restore app', async function () {
         const backups = JSON.parse(execSync(`cloudron backup list --raw --app ${app.id}`));
         execSync('cloudron uninstall --app ' + app.id, EXEC_ARGS);
         execSync('cloudron install --location ' + LOCATION, EXEC_ARGS);
         getAppInfo();
         execSync(`cloudron restore --backup ${backups[0].id} --app ${app.id}`, EXEC_ARGS);
+        await timers.setTimeout(10000);
     });
 
     it('can login', login.bind(null, 'minioakey', 'minioskey'));
     it('has bucket', checkBucket);
-    it('can open settings', openSettings);
     it('can logout', logout);
+    it('does redirect', checkRedirect);
+    it('check api', checkApi);
 
-    it('move to different location', function () {
+    it('move to different location', async function () {
         browser.manage().deleteAllCookies();
         execSync('cloudron configure --location ' + LOCATION + '2', EXEC_ARGS);
+        await timers.setTimeout(10000);
     });
     it('can get app information', getAppInfo);
 
     it('can login', login.bind(null, 'minioakey', 'minioskey'));
     it('has bucket', checkBucket);
     it('can logout', logout);
+    it('does redirect', checkRedirect);
+    it('check api', checkApi);
 
     it('uninstall app', function () { execSync('cloudron uninstall --app ' + app.id, EXEC_ARGS); });
 
@@ -202,12 +167,15 @@ describe('Application life cycle test', function () {
     it('can login', login.bind(null, 'minioadmin', 'minioadmin'));
     it('can add buckets', addBucket);
     it('can logout', logout);
-    it('can update', function () { execSync('cloudron update --app ' + LOCATION, EXEC_ARGS); });
+    it('can update', function () { execSync(`cloudron update --app ${LOCATION}`, EXEC_ARGS); });
+    it('can configure', function () { execSync(`cloudron configure --app ${LOCATION} --location ${LOCATION} --secondary-domains API_SERVER_DOMAIN=${LOCATION}-api`, EXEC_ARGS); });
     it('can get app information', getAppInfo);
 
     it('can login', login.bind(null, 'minioadmin', 'minioadmin'));
     it('has bucket', checkBucket);
     it('can logout', logout);
+    it('does redirect', checkRedirect);
+    it('check api', checkApi);
 
     it('uninstall app', function () { execSync('cloudron uninstall --app ' + app.id, EXEC_ARGS); });
 });