Version 1.26.4

CHANGELOG.md

@@ -912,3 +912,250 @@
 * Update Gitea to 1.16.3
 * [Full changelog](https://github.com/go-gitea/gitea/releases/tag/v1.16.3)
 
+[1.23.8]
+* Update Gitea to 1.16.4
+* [Full changelog](https://github.com/go-gitea/gitea/releases/tag/v1.16.4)
+* Restrict email address validation (#17688) (#19085)
+* Fix lfs bug (#19072) (#19080)
+
+[1.23.9]
+* Update Gitea to 1.16.5
+* [Full changelog](https://github.com/go-gitea/gitea/releases/tag/v1.16.5)
+* Prevent redirect to Host (2) (#19175) (#19186)
+* Try to prevent autolinking of displaynames by email readers (#19169) (#19183)
+* Clean paths when looking in Storage (#19124) (#19179)
+* Do not send notification emails to inactive users (#19131) (#19139)
+* Do not send activation email if manual confirm is set (#19119) (#19122)
+
+[1.23.10]
+* Update Gitea to 1.16.6
+* [Full changelog](https://github.com/go-gitea/gitea/releases/tag/v1.16.6)
+
+[1.23.11]
+* Update Gitea to 1.16.7
+* [Full changelog](https://github.com/go-gitea/gitea/releases/tag/v1.16.7)
+* Escape git fetch remote (#19487) (#19490)
+* On Migrations, only write commit-graph if wiki clone was successful (#19563) (#19568)
+* Respect DefaultUserIsRestricted system default when creating new user (#19310) (#19560)
+* Don't error when branch's commit doesn't exist (#19547) (#19548)
+* Support hostname:port to pass host matcher's check (#19543) (#19544)
+* Prevent dangling archiver goroutine (#19516) (#19526)
+* Fix migrate release from github (#19510) (#19523)
+* When view `_Siderbar` or `_Footer`, just display once (#19501) (#19522)
+* Fix blame page select range error and some typos (#19503)
+* Fix name of doctor fix "authorized-keys" in hints (#19464) (#19484)
+* User specific repoID or xorm builder conditions for issue search (#19475) (#19476)
+* Prevent dangling cat-file calls (goroutine alternative) (#19454) (#19466)
+* RepoAssignment ensure to close before overwrite (#19449) (#19460)
+* Set correct PR status on 3way on conflict checking (#19457) (#19458)
+* Mark TemplateLoading error as "UnprocessableEntity" (#19445) (#19446)
+
+[1.23.12]
+* Update Gitea to 1.16.8
+* [Full changelog](https://github.com/go-gitea/gitea/releases/tag/v1.16.8)
+* Add doctor check/fix for bogus action rows (#19656) (#19669)
+* Make .cs highlighting legible on dark themes (#19604) (#19605)
+* Delete user related oauth stuff on user deletion too (#19677) (#19680)
+* Fix new release from tags list UI (#19670) (#19673)
+* Prevent NPE when checking repo units if the user is nil (#19625) (#19630)
+
+[1.24.0]
+* Update Gitea to 1.17.0
+* [Full changelog](https://github.com/go-gitea/gitea/releases/tag/v1.17.0)
+* Automatically render wiki TOC (#19873)
+* Adding button to link accounts from user settings (#19792)
+* Allow set default merge style while creating repo (#19751)
+* Auto merge pull requests when all checks succeeded (#9307 & #19648)
+* Improve reviewing PR UX (#19612)
+* Add support for rendering console output with colors (#19497)
+
+[1.24.1]
+* Update Gitea to 1.17.1
+* [Full changelog](https://github.com/go-gitea/gitea/releases/tag/v1.17.1)
+* Correctly escape within tribute.js (#20831) (#20832)
+* Add support for NuGet API keys (#20721) (#20734)
+* Display project in issue list (#20583)
+* Add disable download source configuration (#20548) (#20579)
+* Add username check to doctor (#20140) (#20671)
+* Enable Wire 2 for Internal SSH Server (#20616) (#20617)
+* Use the total issue count for UI (#20785) (#20827)
+* Add proxy host into allow list (#20798) (#20819)
+* Add missing translation for queue flush workers (#20791) (#20792)
+* Improve comment header for mobile (#20781) (#20789)
+* Fix git.Init for doctor sub-command (#20782) (#20783)
+* Check webhooks slice length before calling xorm (#20642) (#20768)
+* Remove manual rollback for failed generated repositories (#20639) (#20762)
+* Use correct field name in npm template (#20675) (#20760)
+* Keep download count on Container tag overwrite (#20728) (#20735)
+* Fix v220 migration to be compatible for MSSQL 2008 r2 (#20702) (#20707)
+* Use request timeout for git service rpc (#20689) (#20693)
+* Send correct NuGet status codes (#20647) (#20677)
+* Use correct context to get package content (#20673) (#20676)
+* Fix the JS error "EventSource is not defined" caused by some non-standard browsers (#20584) (#20663)
+* Add default commit messages to PR for squash merge (#20618) (#20645)
+* Fix package upload for files >32mb (#20622) (#20635)
+* Fix the new-line copy-paste for rendered code (#20612)
+* Clean up and fix clone button script (#20415 & #20600) (#20599)
+* Fix default merge style (#20564) (#20565)
+* Add repository condition for issue count (#20454) (#20496)
+* Make branch icon stand out more (#20726) (#20774)
+* Fix loading button with invalid form (#20754) (#20759)
+* Fix SecToTime edge-cases (#20610) (#20611)
+* Executable check always returns true for windows (#20637) (#20835)
+* Check issue labels slice length before calling xorm Insert (#20655) (#20836)
+* Fix owners cannot create organization repos bug (#20841) (#20854)
+* Prevent 500 is head repo does not have PullRequest unit in IsUserAllowedToUpdate (#20839) (#20848)
+
+[1.24.2]
+* Update Gitea to 1.17.2
+* [Full changelog](https://github.com/go-gitea/gitea/releases/tag/v1.17.2)
+* Double check CloneURL is acceptable (#20869) (#20892)
+* Add more checks in migration code (#21011) (#21050)
+* Fix hard-coded timeout and error panic in API archive download endpoint (#20925) (#21051)
+* Improve arc-green code theme (#21039) (#21042)
+* Enable contenthash in filename for dynamic assets (#20813) (#20932)
+* Don't open new page for ext wiki on same repository (#20725) (#20910)
+* Disable doctor logging on panic (#20847) (#20898)
+* Remove calls to load Mirrors in user.Dashboard (#20855) (#20897)
+* Update codemirror to 5.65.8 (#20875)
+* Rework repo buttons (#20602, #20718) (#20719)
+* Ensure delete user deletes all comments (#21067) (#21068)
+* Delete unreferenced packages when deleting a package version (#20977) (#21060)
+* Redirect if user does not exist on admin pages (#20981) (#21059)
+* Set uploadpack.allowFilter etc on gitea serv to enable partial clones with ssh (#20902) (#21058)
+* Fix 500 on time in timeline API (#21052) (#21057)
+* Fill the specified ref in webhook test payload (#20961) (#21055)
+* Add another index for Action table on postgres (#21033) (#21054)
+* Fix broken insecureskipverify handling in redis connection uris (#20967) (#21053)
+* Add Dev, Peer and Optional dependencies to npm PackageMetadataVersion (#21017) (#21044)
+* Do not add links to Posters or Assignees with ID < 0 (#20577) (#21037)
+* Fix modified due date message (#20388) (#21032)
+* Fix missed sort bug (#21006)
+* Fix input.value attr for RequiredClaimName/Value (#20946) (#21001)
+* Change review buttons to icons to make space for text (#20934) (#20978)
+* Fix download archiver of a commit (#20962) (#20971)
+* Return 404 NotFound if requested attachment does not exist (#20886) (#20941)
+* Set no-tags in git fetch on compare (#20893) (#20936)
+* Allow multiple metadata files for Maven packages (#20674) (#20916)
+* Increase Content field size of gpg_key and public_key to MEDIUMTEXT (#20896) (#20911)
+* Fix mirror address setting not working (#20850) (#20904)
+* Fix push mirror address backend get error Address cause setting page display error (#20593) (#20901)
+* Fix panic when an invalid oauth2 name is passed (#20820) (#20900)
+* In PushMirrorsIterate and MirrorsIterate if limit is negative do not set it (#20837) (#20899)
+* Ensure that graceful start-up is informed of unused SSH listener (#20877) (#20888)
+* Pad GPG Key ID with preceding zeroes (#20878) (#20885)
+* Fix SQL Query for SearchTeam (#20844) (#20872)
+* Fix the mode of custom dir to 0700 in docker-rootless (#20861) (#20867)
+* Fix UI mis-align for PR commit history (#20845) (#20859)
+
+[1.24.3]
+* Update Gitea to 1.17.3
+* [Full changelog](https://github.com/go-gitea/gitea/releases/tag/v1.17.3)
+* SECURITY
+  * Sanitize and Escape refs in git backend (#21464) (#21463)
+  * Bump golang.org/x/text (#21412) (#21413)
+  * Update bluemonday (#21281) (#21287)
+* ENHANCEMENTS
+  * Fix empty container layer history and UI (#21251) (#21278)
+  * Use en-US as fallback when using other default language (#21200) (#21256)
+  * Make the vscode clone link respect transport protocol (#20557) (#21128)
+
+[1.24.4]
+* Make email display name configurable
+
+[1.24.5]
+* Support autosigning via gnupg
+
+[1.25.0]
+* Update Gitea to 1.17.4
+* [Full changelog](https://github.com/go-gitea/gitea/releases/tag/v1.17.4)
+* Do not allow Ghost access to limited visible user/org (#21849) (#21875)
+* Fix package access for admins and inactive users (#21580) (#21592)
+* Fix button in branch list, avoid unexpected page jump before restore branch actually done (#21562) (#21927)
+* Fix vertical align of committer avatar rendered by email address (#21884) (#21919)
+* Fix setting HTTP headers after write (#21833) (#21874)
+* Ignore line anchor links with leading zeroes (#21728) (#21777)
+* Enable Monaco automaticLayout (#21516)
+
+[1.25.1]
+* Trust reverse proxy IP
+
+[1.26.0]
+* Update Gitea to 1.18.0
+* [Full changelog](https://github.com/go-gitea/gitea/releases/tag/v1.18.0)
+* Remove ReverseProxy authentication from the API (#22219) (#22251)
+* Support Go Vulnerability Management (#21139)
+* Forbid HTML string tooltips (#20935)
+* Rework mailer settings (#18982)
+* Remove U2F support (#20141)
+* Refactor i18n to locale (#20153)
+* Enable contenthash in filename for dynamic assets (#20813)
+* And a lot more enhancements
+
+[1.26.1]
+* Update Gitea to 1.18.1
+* [Full changelog](https://github.com/go-gitea/gitea/releases/tag/v1.18.1)
+* Update github.com/zeripath/zapx/v15 (#22485)
+* Fix pull request API field closed_at always being null (#22482) (#22483)
+* Fix container blob mount (#22226) (#22476)
+* Fix error when calculating repository size (#22392) (#22474)
+* Fix Operator does not exist bug on explore page with ONLY_SHOW_RELEVANT_REPOS (#22454) (#22472)
+* Fix environments for KaTeX and error reporting (#22453) (#22473)
+* Remove the netgo tag for Windows build (#22467) (#22468)
+* Fix migration from GitBucket (#22477) (#22465)
+* Prevent panic on looking at api "git" endpoints for empty repos (#22457) (#22458)
+* Fix PR status layout on mobile (#21547) (#22441)
+* Fix wechatwork webhook sends empty content in PR review (#21762) (#22440)
+* Remove duplicate "Actions" label in mobile view (#21974) (#22439)
+* Fix leaving organization bug on user settings -> orgs (#21983) (#22438)
+* Fixed colour transparency regex matching in project board sorting (#22092) (#22437)
+* Correctly handle select on multiple channels in Queues (#22146) (#22428)
+* Prepend refs/heads/ to issue template refs (#20461) (#22427)
+* Restore function to "Show more" buttons (#22399) (#22426)
+* Continue GCing other repos on error in one repo (#22422) (#22425)
+* Allow HOST has no port (#22280) (#22409)
+* Fix omit `avatar_url` in discord payload when empty (#22393) (#22394)
+* Don't display stop watch top bar icon when disabled and hidden when click other place (#22374) (#22387)
+* Don't lookup mail server when using sendmail (#22300) (#22383)
+* Fix gravatar disable bug (#22337)
+* Fix update settings table on install (#22326) (#22327)
+* Fix sitemap (#22272) (#22320)
+* Fix code search title translation (#22285) (#22316)
+* Fix due date rendering the wrong date in issue (#22302) (#22306)
+* Fix get system setting bug when enabled redis cache (#22298)
+* Fix bug of DisableGravatar default value (#22297)
+* Fix key signature error page (#22229) (#22230)
+
+[1.26.2]
+* Update Gitea to 1.18.2
+* [Full changelog](https://github.com/go-gitea/gitea/releases/tag/v1.18.2)
+* When updating by rebase we need to set the environment for head repo (#22535) (#22536)
+* Fix issue not auto-closing when it includes a reference to a branch (#22514) (#22521)
+* Fix invalid issue branch reference if not specified in template (#22513) (#22520)
+* Fix 500 error viewing pull request when fork has pull requests disabled (#22512) (#22515)
+* Reliable selection of admin user (#22509) (#22511)
+* Set `disable_gravatar`/`enable_federated_avatar` when offline mode is true (#22479) (#22496)
+
+[1.26.3]
+* Update Gitea to 1.18.3
+* [Full changelog](https://github.com/go-gitea/gitea/releases/tag/v1.18.3)
+* Prevent multiple To recipients (#22566) (#22569)
+* Truncate commit summary on repo files table. (#22551) (#22552)
+* Mute all links in issue timeline (#22534)
+
+[1.26.4]
+* Update Gitea to 1.18.4
+* [Full changelog](https://github.com/go-gitea/gitea/releases/tag/v1.18.4)
+* SECURITY
+  * Provide the ability to set password hash algorithm parameters (#22942) (#22943)
+  * Add command to bulk set must-change-password (#22823) (#22928)
+* ENHANCEMENTS
+  * Use import of OCI structs (#22765) (#22805)
+  * Fix color of tertiary button on dark theme (#22739) (#22744)
+  * Link issue and pull requests status change in UI notifications directly to their event in the timelined view. (#22627) (#22642)
+* BUGFIXES
+  * Notify on container image create (#22806) (#22965)
+  * Fix blame view missing lines (#22826) (#22929)
+  * Fix incorrect role labels for migrated issues and comments (#22914) (#22923)
+  * Fix PR file tree folders no longer collapsing (#22864) (#22872)
+  * Escape filename when assemble URL (#22850) (#22871)

CloudronManifest.json

@@ -4,8 +4,8 @@
   "author": "Gitea developers",
   "description": "file://DESCRIPTION.md",
   "tagline": "A painless self-hosted Git Service",
-  "version": "1.23.7",
-  "upstreamVersion": "1.16.3",
+  "version": "1.26.4",
+  "upstreamVersion": "1.18.4",
   "healthCheckPath": "/explore",
   "httpPort": 3000,
   "memoryLimit": 536870912,
@@ -35,9 +35,9 @@
     "https://screenshots.cloudron.io/io.gitea.cloudronapp/5.png"
   ],
   "tags": [ "version control", "git", "code hosting", "development", "github", "bitbucket", "gitlab" ],
-  "changelog": "file://CHANGELOG",
+  "changelog": "file://CHANGELOG.md",
   "postInstallMessage": "file://POSTINSTALL.md",
-  "minBoxVersion": "7.1.2",
+  "minBoxVersion": "7.2.0",
   "forumUrl": "https://forum.cloudron.io/category/19/gitea",
   "documentationUrl": "https://docs.cloudron.io/apps/gitea/"
 }

Dockerfile

@@ -1,4 +1,4 @@
-FROM cloudron/base:3.2.0@sha256:ba1d566164a67c266782545ea9809dc611c4152e27686fd14060332dd88263ea
+FROM cloudron/base:4.0.0@sha256:31b195ed0662bdb06a6e8a5ddbedb6f191ce92e8bee04c03fb02dd4e9d0286df
 
 RUN apt-get update && \
     apt-get install -y openssh-server git asciidoctor pandoc && \
@@ -16,7 +16,10 @@ RUN passwd -d git
 RUN mkdir -p /home/git/gitea
 WORKDIR /home/git
 
-ARG VERSION=1.16.3
+# for autosign feature
+ENV GNUPGHOME="/app/data/gnupg"
+
+ARG VERSION=1.18.4
 
 RUN curl -L https://dl.gitea.io/gitea/${VERSION}/gitea-${VERSION}-linux-amd64 -o /home/git/gitea/gitea \
     && chmod +x /home/git/gitea/gitea

app.ini.template

@@ -64,7 +64,8 @@ SKIP_VERIFY = true
 ; those settings are protected and can't be modified
 INSTALL_LOCK = true
 SECRET_KEY = ##SECRET_KEY
-
+REVERSE_PROXY_LIMIT = 1
+REVERSE_PROXY_TRUSTED_PROXIES = *
 
 [service]
 DISABLE_REGISTRATION = false

start.sh

@@ -28,7 +28,7 @@ setup_ldap_source() {
 setup_root_user() {
     set -eu
 
-    if sudo -H -u git /home/git/gitea/gitea admin user create --username root --password changeme --email test@cloudron.io --admin -c /run/gitea/app.ini; then
+    if sudo -H -u git /home/git/gitea/gitea admin user create --username root --password changeme --email admin@cloudron.local --admin -c /run/gitea/app.ini; then
         echo "==> root user added"
     else
         echo "==> Failed to add root user"
@@ -117,16 +117,17 @@ crudini --set "/run/gitea/app.ini" mailer PASSWD "${CLOUDRON_MAIL_SMTP_PASSWORD}
 crudini --set "/run/gitea/app.ini" mailer FROM "${CLOUDRON_MAIL_FROM}"
 crudini --set "/run/gitea/app.ini" mailer SKIP_VERIFY "true"
 crudini --set "/run/gitea/app.ini" security INSTALL_LOCK "true"
+crudini --set "/run/gitea/app.ini" security REVERSE_PROXY_LIMIT 1
+crudini --set "/run/gitea/app.ini" security REVERSE_PROXY_TRUSTED_PROXIES "*"
 crudini --set "/run/gitea/app.ini" log MODE "console"
 crudini --set "/run/gitea/app.ini" log ROOT_PATH "/run/gitea"
 crudini --set "/run/gitea/app.ini" indexer ISSUE_INDEXER_PATH "/app/data/appdata/indexers/issues.bleve"
 
 echo "==> Creating dirs and changing permissions"
-mkdir -p /app/data/repository /app/data/ssh /app/data/custom
+mkdir -p /app/data/repository /app/data/ssh /app/data/custom /app/data/gnupg
 chown -R git:git /app/data /run/gitea
 
 # this expects app.ini to be available
 ( setup_auth ) &
 
 exec /usr/bin/supervisord --configuration /etc/supervisor/supervisord.conf --nodaemon -i Gitea
-

supervisor/sshd.conf

@@ -8,4 +8,3 @@ stdout_logfile=/dev/stdout
 stdout_logfile_maxbytes=0
 stderr_logfile=/dev/stderr
 stderr_logfile_maxbytes=0
-

test/package.json

@@ -9,11 +9,10 @@
   "author": "",
   "license": "ISC",
   "dependencies": {
-    "chromedriver": "^98.0.1",
+    "chromedriver": "^110.0.0",
     "expect.js": "^0.3.1",
-    "mocha": "^9.2.1",
-    "rimraf": "^3.0.2",
-    "selenium-webdriver": "^4.1.1",
-    "superagent": "^7.1.1"
+    "mocha": "^10.2.0",
+    "selenium-webdriver": "^4.8.1",
+    "superagent": "^8.0.9"
   }
 }

test/test.js

@@ -75,10 +75,10 @@ describe('Application life cycle test', function () {
     async function checkAvatar() {
         await browser.get(`https://${app.fqdn}/${username}`);
 
-        var avatarSrc = await browser.findElement(By.xpath('//a[@id="profile-avatar"]/img')).getAttribute('src');
+        const avatarSrc = await browser.findElement(By.xpath('//div[@id="profile-avatar"]/a/img')).getAttribute('src');
 
-        var avatar = await superagent.get(avatarSrc);
-        expect(avatar.statusCode).to.equal(200);
+        const response = await superagent.get(avatarSrc);
+        expect(response.statusCode).to.equal(200);
     }
 
     async function login(username, password) {
@@ -153,9 +153,9 @@ describe('Application life cycle test', function () {
     }
 
     function pushFile() {
-        var env = Object.create(process.env);
+        const env = Object.create(process.env);
         env.GIT_SSH = __dirname + '/git_ssh_wrapper.sh';
-        execSync(`touch newfile && git add newfile && git commit -a -mx && git push ssh://git@${app.fqdn}:${SSH_PORT}/${username}/${reponame} master`,
+        execSync(`touch newfile && git add newfile && git commit -a -mx && git push ssh://git@${app.fqdn}:${SSH_PORT}/${username}/${reponame} main`,
                  { env: env, cwd: repodir });
         fs.rmSync(repodir, { recursive: true, force: true });
     }
@@ -258,10 +258,11 @@ describe('Application life cycle test', function () {
     it('can add and push a file', pushFile);
 
     it('can update', function () { execSync('cloudron update --app ' + app.id, EXEC_ARGS); });
+    it('can get app information', getAppInfo);
 
-    xit('can admin login', adminLogin);
-    xit('can send mail', sendMail);
-    xit('can logout', logout);
+    it('can admin login', adminLogin);
+    it('can send mail', sendMail);
+    it('can logout', logout);
 
     it('can login', login.bind(null, username, password));
     it('can get avatar', checkAvatar);